Skip to content

sqlite3 Connection maintains an unused list of weakrefs to Cursor objects #144377

New issue
New issue
Open
#144378
Open
sqlite3 Connection maintains an unused list of weakrefs to Cursor objects#144377
#144378
Labels
extension-modulesC modules in the Modules dirtopic-sqlite3type-featureA feature request or enhancement
@takluyver

Description

@takluyver
takluyver
opened on Feb 1, 2026

The sqlite3 Connection object creates a list to hold weakrefs to Cursors, and each cursor registers itself in that list when it's created.

cpython/Modules/_sqlite/connection.c

Lines 289 to 293 in b625601

PyObject *cursors = PyList_New(0);
if (cursors == NULL) {
Py_DECREF(statement_cache);
goto error;
}

cpython/Modules/_sqlite/cursor.c

Lines 108 to 122 in b625601

register_cursor(pysqlite_Connection *connection, PyObject *cursor)
{
PyObject *weakref = PyWeakref_NewRef((PyObject *)cursor, NULL);
if (weakref == NULL) {
return 0;
}
if (PyList_Append(connection->cursors, weakref) < 0) {
Py_CLEAR(weakref);
return 0;
}
Py_DECREF(weakref);
return 1;
}

There's code to periodically clear out dead weakrefs from the list, but nothing I can see that actually uses it. It looks like the use was removed in #26026.

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    extension-modulesC modules in the Modules dirtopic-sqlite3type-featureA feature request or enhancement

    Projects

    sqlite3 issues

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions