-
Notifications
You must be signed in to change notification settings - Fork 9
Move tutorial to Jekyll website #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging you for review @samcunliffe as you did some previous investigation on related issue #577 but appreciate you've just reviewed two other PRs from me so no worries if you want to pass on this one! |
It looks like |
samcunliffe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works! 🥳
| from the root of the project repository. Note that `uv>=0.6.7` is required to use the `--group` option. | ||
|
|
||
| <details><summary>Using venv as an alternative to uv </summary> <!-- markdownlint-disable-line MD033 --> | ||
| <details markdown="1"><summary markdown="span">Using venv as an alternative to uv </summary> <!-- markdownlint-disable-line MD033 --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My limited understanding of this is that these attributes give extra information to the Kramdown Markdown processor to avoid it mangling the HTML blocks. I found them from a blog post which references a GitHub issue on GitHub Docs repository.
Resolves #577
Moves template tutorial under website
docs/pagesdirectory and updates internal links to point to new location.To get GFM admonitions to render on Jekyll site also adds jekyll-gdm-admonitions plugin as a new dependency on site config and Gemfile. As an alternative we could use the built-in support for callouts / admonitions in the Just the Docs theme. This would then no longer render on GitHub though.
I have currently updated the link on main README to still be version on GitHub rather than rendered website - not sure if we want to change this or not.
The additional attributes on
<details>/<summary>tags are taken from this blog post.