refactor(config): replace is_empty_config with contains_commitizen_section, improve multi config resolution algorithm #1842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1842 +/- ##
==========================================
+ Coverage 97.98% 98.00% +0.01%
==========================================
Files 60 60
Lines 2686 2703 +17
==========================================
+ Hits 2632 2649 +17
Misses 54 54 ☔ View full report in Codecov by Sentry. |
…ction, improve multi config resolution algorithm
bearomorphism
force-pushed
the
remove-is-empty-config
branch
from
40c5b7b to
922bf56
Compare
bearomorphism
commented
Feb 3, 2026
Comment on lines
+23
to
+28
| def contains_commitizen_section(self) -> bool: | ||
| """Check if the config file contains a commitizen section. | ||
|
|
||
| The implementation is different for each config file type. | ||
| """ | ||
| raise NotImplementedError() |
Collaborator
Author
There was a problem hiding this comment.
Not sure whether this is a good enough design. I think the state is_empty_config is a bit hard to track. The property is only used in read_cfg function call though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
samefile_resolve_config_candidates. The tests already covered the cases "same git repo root and cwd" so it should not be broken after merging this PR._parse_settingsWhy removing
is_empty_config?Hmm, I believe a stateless function is easier to read in this case.