feat(seer): Update Seer settings so that PR Create toggles respect enableSeerCoding #107391
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| )} | ||
| </Flex> | ||
| ), | ||
| key: 'pr_creation', |
There was a problem hiding this comment.
Bulk action bypasses enableSeerCoding restriction for PR Creation
Medium Severity
The PR Creation column header tooltip and individual row switches correctly check organization.enableSeerCoding === false to disable the feature, but the bulk action DropdownMenu for "PR Creation" (shown when projects are selected) only checks canWrite. Users can bypass the enableSeerCoding restriction by selecting multiple projects and using the bulk dropdown to enable PR creation, even when code generation is disabled at the org level.
Additional Locations (1)
| )} | ||
| </Alert> | ||
| )} | ||
| </Flex> |
There was a problem hiding this comment.
Settings toggle not disabled when code generation disabled
Medium Severity
The autoOpenPrs field shows an Alert warning when organization.enableSeerCoding === false, but unlike the project-level components (seerAgentSection.tsx and seerProjectTableRow.tsx), it doesn't disable the toggle. This allows users to enable the setting despite the warning that it won't work. The field definition supports a disabled property (as seen in the form types), but one isn't provided for this case, creating inconsistent behavior across the UI.
| ), | ||
| } | ||
| )} | ||
| </Alert> |
There was a problem hiding this comment.
Duplicated warning message pattern across three files
Low Severity
The identical tct('[settings:"Enable Code Generation"] must be enabled...') message with the same Link to={...seer/#enableSeerCoding} pattern is duplicated across three files. Consider extracting this into a shared helper function or constant (e.g., getSeerCodingDisabledMessage(orgSlug)) to reduce maintenance burden.
Fixes CW-733