Skip to content

Conversation

@juanarbol
Copy link
Member

Fixes: #61116

Fixes: nodejs#61116
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Dec 26, 2025
@codecov
Copy link

codecov bot commented Dec 27, 2025

Codecov Report

❌ Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (5e677d6) to head (6989430).
⚠️ Report is 257 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 73.91% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61178      +/-   ##
==========================================
+ Coverage   88.52%   88.53%   +0.01%     
==========================================
  Files         703      703              
  Lines      208585   208610      +25     
  Branches    40225    40235      +10     
==========================================
+ Hits       184650   184702      +52     
+ Misses      15953    15911      -42     
- Partials     7982     7997      +15     
Files with missing lines Coverage Δ
lib/fs.js 98.18% <100.00%> (+<0.01%) ⬆️
lib/internal/fs/promises.js 98.15% <100.00%> (+<0.01%) ⬆️
src/node_file.cc 75.47% <73.91%> (-0.05%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2026
@juanarbol
Copy link
Member Author

@jasnell PTAL

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2026
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fs.promises.stat: Missing option throwIfNoEntry

4 participants