Skip to content

Conversation

@OsamuBlack
Copy link

This PR is attempting to close #668.

  • Added "Move Up" and "Move Down" buttons to the DraggableComponent's action bar, with corresponding icons and logic to dispatch move actions and update UI selection. Actions are disabled when the item is at the boundary or drag is not permitted.
  • Checks permissions.drag before moving.
  • Uses MoveUp/MoveDown lucide-react icons
  • Disabled action state
  • Only use isLast to disable the onMoveDown

Known Issues:

  • onMoveUp does not rerender the selection.

…ionBar. Added disabled state to ActionBar.Action.
@vercel
Copy link

vercel bot commented Sep 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
puck-demo Ready Ready Preview Comment Oct 6, 2025 9:43am
puck-docs Ready Ready Preview Oct 6, 2025 9:43am

@vercel
Copy link

vercel bot commented Sep 16, 2025

@OsamuBlack is attempting to deploy a commit to the Puck Team on Vercel.

A member of the Team first needs to authorize it.

@FedericoBonel
Copy link
Collaborator

The issue tracking the move up overlay rendering problem is this one: #955

@FedericoBonel
Copy link
Collaborator

Following this up with the last action we set up from the previous PR:

Hey @OsamuBlack sorry for the delay! I think this PR has the right bones, but still needs a bit of work from a UX point of view. It'll be easier for me to take it over the line at this point. Will finish it up soon.

This would also involve fixing the functional problems with the overlay not moving with the component (#955).

Copy link
Collaborator

@FedericoBonel FedericoBonel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a request for changes so we can review this again and apply the necessary updates before merging, following up on the last comment from the previous PR.

@OsamuBlack
Copy link
Author

Adding a request for changes so we can review this again and apply the necessary updates before merging, following up on the last comment from the previous PR.

Anything I need to check or change?

@FedericoBonel
Copy link
Collaborator

Not on your end @OsamuBlack! Thanks again for the contribution, we just need to fix the overlay not moving bug and the UX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding up/down and add buttons in Action Bar

2 participants