Skip to content

Conversation

@smontanaro
Copy link
Contributor

No description provided.

@StanFromIreland StanFromIreland changed the title possible warning message when cpu resource is missing test_xpickle: warning message when cpu resource is missing Jan 30, 2026
@StanFromIreland StanFromIreland changed the title test_xpickle: warning message when cpu resource is missing test_xpickle: Mark cpu resource as required Jan 30, 2026
@encukou
Copy link
Member

encukou commented Feb 2, 2026

@smontanaro, did you intend to close this, or was it a mistake?

(The commits are still recoverable: a201c26 12c4b35 e967287)

@smontanaro
Copy link
Contributor Author

Side effect of trying to fix my repo. I thought the trivial changes had already been committed, so didn't worry about it.

Didn't someone (Serhiy?) comment that the cpu resource is no longer required anyway?

@encukou
Copy link
Member

encukou commented Feb 2, 2026

Ah! I didn't see the conversation, but it makes sense to me. With the specific xpickle resource, cpu does look redundant.

So, let's keep it closed. For posterity, the patch was:

--- a/Lib/test/test_xpickle.py
+++ b/Lib/test/test_xpickle.py
@@ -18,8 +18,9 @@
     has_c_implementation = False
 
 support.requires('xpickle')
+support.requires('cpu')
 
 is_windows = sys.platform.startswith('win')
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants