gh-139103: Use METH_FASTCALL for tp_new_wrapper #144406
Merged
+18
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses one of the bottlenecks when constructing namedtuple instances. With the previous METH_VARARGS, the type argument to __new__ would be included in the arguments tuple, leading to reference count contention.
Contributor
Author
|
A few comments:
|
vstinner
approved these changes
Feb 2, 2026
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
I'm not sure what's wrong with the CI.
Contributor
Author
|
I think there are site-wide failures with GitHub Actions hosted-runners: https://www.githubstatus.com/ |
kumaraditya303
approved these changes
Feb 3, 2026
Aniketsy
pushed a commit
to Aniketsy/cpython
that referenced
this pull request
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses one of the bottlenecks when constructing namedtuple instances. With the previous METH_VARARGS, the type argument to
__new__would be included in the arguments tuple, leading to reference count contention.