Revert "Save work on emitting ignored diagnostics pt 2" #20716
Merged
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 195ab98.
Member
|
Just curious, did this cause some problems? |
Collaborator
Author
|
Yes, the second PR did, see #20696 (comment) |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Member
|
Hm, OK, I see. Maybe you can simply check if there any active error watchers (IIRC I already needed this for something, so I am quite this should be easy)? This should allow skipping a bunch more error-emitting code. |
Collaborator
Author
|
Will do! |
Collaborator
Author
|
Merging this for now to keep master usable, will follow up with the watcher change + better testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #20696